Skip to content

add confidence score for geoIp#31

Merged
vigan-abd merged 4 commits into
bitfinexcom:stagingfrom
bilalfastnu:geoip-confidence-score
Sep 11, 2025
Merged

add confidence score for geoIp#31
vigan-abd merged 4 commits into
bitfinexcom:stagingfrom
bilalfastnu:geoip-confidence-score

Conversation

@bilalfastnu
Copy link
Copy Markdown
Contributor

  • Calculates confidence score for geoIp based on the accuracy_radius.
  • Higher the accuracy_radius lesser the confidence, shorter the accuracy_radius better the confidenceScore

Ticket

Comment thread workers/loc.api/net.util.js Outdated
const accuracyRadius = geo.area

// Define a max expected radius beyond which confidence is zero
const maxExpectedRadius = 500 // kilometers
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to config please

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved!

tarcisiozf
tarcisiozf previously approved these changes Sep 8, 2025
@vigan-abd vigan-abd changed the base branch from master to staging September 8, 2025 16:49
@vigan-abd vigan-abd dismissed tarcisiozf’s stale review September 8, 2025 16:49

The base branch was changed.

@vigan-abd vigan-abd merged commit 54d4e8b into bitfinexcom:staging Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants